[DPE-7678] recreate predefined roles #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
changed the title
dragomirp
force-pushed
the
dpe-7678-recreate-predefined-roles
branch
from
faad5af to
149fa04
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1017 +/- ##
========================================
Coverage 70.28% 70.28%
========================================
Files 16 16
Lines 3806 3806
Branches 545 545
========================================
Hits 2675 2675
Misses 1001 1001
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-7678-recreate-predefined-roles
branch
from
24d19f7 to
5110adb
Compare
dragomirp
force-pushed
the
dpe-7678-recreate-predefined-roles
branch
2 times, most recently
from
4c7a411 to
9e8929e
Compare
dragomirp
force-pushed
the
dpe-7678-recreate-predefined-roles
branch
from
9e8929e to
baf3220
Compare
|
It is almost perfect! I do not see:
Other parts looks perfect!!! |
dragomirp
commented
Jul 7, 2025
| ) | ||
|
|
||
| await ops_test.model.wait_for_idle(status="active", timeout=1500) | ||
| await ops_test.model.wait_for_idle(status="active", timeout=1800) |
There was a problem hiding this comment.
Test failed with timeouts consistently in a previous run: https://github.com/canonical/postgresql-operator/actions/runs/16083228579
taurus-forever
approved these changes
Jul 7, 2025
dragomirp
commented
Jul 7, 2025
| connection = None | ||
| try: | ||
| for database in ["postgres", "template1"]: | ||
| for database in self._get_existing_databases(): |
There was a problem hiding this comment.
Moving the loop in set_up_database and passing a cursor made the plugin test fail consistently: https://github.com/canonical/postgresql-operator/actions/runs/16081464233/job/45386910548
unit-postgresql-0: 22:27:52 ERROR unit.postgresql/0.juju-log __main__:Failed to disable plugin: cannot drop table pg_hba because extension orafce requires it
HINT: You can drop extension orafce instead.
CONTEXT: SQL statement "DROP TABLE IF EXISTS pg_hba"
PL/pgSQL function update_pg_hba() line 13 at SQL statement
SQL statement "CREATE SCHEMA tiger_data"
PL/pgSQL function inline_code_block line 4 at SQL statement
Leaving the separate loops be for now.
marceloneppel
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate roles on existing databases in case when an external backup is being restored within the charm.
Checklist